Add java.io.FilterReader #4912
Add java.io.FilterReader #4912
Conversation
| @@ -364,3 +364,10 @@ class InputStreamReaderTest { | |||
| assertThrows(classOf[IOException], r.mark(0)) | |||
| } | |||
| } | |||
|
|
|||
| class FilterReaderTest { | |||
There was a problem hiding this comment.
This is a bit light, as far as tests goes. Could we at least test that giving it an actual reader as argument allows to call methods of that reader through the filter proxy?
There was a problem hiding this comment.
Also, consider putting this in a dedicated file. I know the current file bundles a lot of them, but that's not great, and we should try not to perpetuate past mistakes. 😅
There was a problem hiding this comment.
I was sort of expecting the nice reused tests like in Collections :-)
I can put the others in separate files as well if you like?
There was a problem hiding this comment.
I can put the others in separate files as well if you like?
If you feel like it, why not :)
| @@ -364,3 +364,4 @@ class InputStreamReaderTest { | |||
| assertThrows(classOf[IOException], r.mark(0)) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Spurious change here, but otherwise LGTM.
Please squash all the commits in a single one with a good commit message. (except separating the existing tests in multiple files; that should be its own commit)
No description provided.