Cleanups to Emitter post transforms #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #4965 to avoid conflicts, but otherwise ready to review. |
gzm0
commented
Mar 24, 2024
linker/shared/src/main/scala/org/scalajs/linker/backend/BasicLinkerBackend.scala
Show resolved
Hide resolved
They are not useful and only make us consume more memory. I initially introduced them because it looked like downstream could avoid running post transforms at all. This seems to not be the case, so there is no point in attempting to provide it.
Further, we move the implementations fully into Emitter: At this point its clear, that there won't really be any others (unless we fundamentally change tree printing).
gzm0
force-pushed
the
no-nested-post-transforms
branch
from
8663a6d
to
09336f3
Compare
|
Rebased on main. |
sjrd
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #4945 made me realize that the post transform concept is more general than we actually need: we do not need general purpose post transformation, just pre-printing.
This PR aligns the code with this notion.