Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify resolver in bindings usage instructions #175

Merged
merged 2 commits into from
Aug 28, 2018

Conversation

kornilova203
Copy link
Member

@kornilova203 kornilova203 commented Aug 27, 2018

Show how to specify url of bintray repo to use bindings.

Instructions are still not valid because artifactId in instructions does not match real one.

For example artifactId for libiconv is libiconv_native0.3 but docs say it's libiconv. I suppose we should change artifactId on bintray because it should not contain version and _native postfix is also strange.
@jonas, I could not figure out how to change artifactId.

To do:

  • Show resolver and dependency in the same code snippet

@@ -0,0 +1,3 @@
// #library_resolver
resolvers += Resolver.bintrayRepo("scala-native-bindgen", "maven")
// #library_resolver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markers are not necessary if you include the whole file.

@kornilova203 kornilova203 merged commit 318a553 into master Aug 28, 2018
@kornilova203 kornilova203 deleted the bindings-resolver-doc branch August 28, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants