Skip to content

Commit

Permalink
Fix JUnit class cast when comparing Float/Double arrays (#3249)
Browse files Browse the repository at this point in the history
* Fix class cast errors in JUnit InexactComparsionCriteria

* Fix invalid signature of sprintf failing in lto:none + release:fast mode

(cherry picked from commit 1ce4944)
  • Loading branch information
WojciechMazur committed May 23, 2023
1 parent 659e37a commit 30fc8ca
Showing 1 changed file with 14 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,19 @@ class InexactComparisonCriteria private (val fDelta: AnyRef)
expected: AnyRef,
actual: AnyRef
): Unit = {
Assert.assertEquals(
expected.asInstanceOf[Double],
actual.asInstanceOf[Double],
fDelta.asInstanceOf[Double]
)
fDelta match {
case delta: java.lang.Double =>
Assert.assertEquals(
expected.asInstanceOf[Double],
actual.asInstanceOf[Double],
delta
)
case delta: java.lang.Float =>
Assert.assertEquals(
expected.asInstanceOf[Float],
actual.asInstanceOf[Float],
delta
)
}
}
}

0 comments on commit 30fc8ca

Please sign in to comment.