Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posixlib grp.scala, pwd.scala, and sys/stat.scala need to use common types from sys/types. #2832

Closed
LeeTibbert opened this issue Sep 3, 2022 · 5 comments · Fixed by #2833
Assignees
Labels
has pr There is a pending PR that addresses this issue

Comments

@LeeTibbert
Copy link
Contributor

Almost always, Single Points of Truth are worth the effort.

Discovered whilst chasing attempting to fix Issue #2831.

I have known about it for years, but it has never bubbled to the
top of my list. Time to do something about it now, so that
fix for #2831 does not get messier than it already needs to be.

@LeeTibbert LeeTibbert changed the title Posixlib grp.scala, pwd.scala, and sys/stat.scala need to use common types in sys/types. Posixlib grp.scala, pwd.scala, and sys/stat.scala need to use common types from sys/types. Sep 3, 2022
LeeTibbert added a commit to LeeTibbert/scala-native-fork that referenced this issue Sep 3, 2022
@LeeTibbert LeeTibbert added the has pr There is a pending PR that addresses this issue label Sep 3, 2022
@LeeTibbert
Copy link
Contributor Author

@WojciechMazur

Could you please consider creating a GitHub Label, similar to 'has_pr' for
'component:posixlib'? Not a necessity, but it would help keep track of what is changing
where. I have found the existing 'component:javalib' to be handy.

Thank you, L.

@WojciechMazur
Copy link
Contributor

Hey @LeeTibbert I've added the request label. That was a good idea. It should help to organize the repo.

Btw. I think that currently, we don't really need a has_pr label. Currently, in GitHub, we can just link an issue with a PR. In multiple cases, it's better because it would automatically close the issue as soon as the related PR is merged. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@LeeTibbert
Copy link
Contributor Author

@wojciech Thank you for the fast turnaround on the component keyword.

Also, thank you, for the URL. I had taken a run at linking issues before
but had not had the benefit of that info. It was not evident how to do so,
so I thought I lacked the privilege.

The "Development" section on the right of my screen has no "gear wheel",
so I wheel. I just took a run at doing it automatically, using the right magic
word in the creation comment, not just in the Title. Seemed to work, so
know I know that I have sufficient privileges.

I think the "has_pr" label still has some value so that other developers
can know at a flash that something is being worked on. Should really
have a, voluntary, "Work started" label that is placed when someone "takes"
an item off the queue. The community is pretty good about
letting folks know about what is being worked on and what is not,
but there are too few of us to waste development cycles on
duplication.

I can stop using the "has_pr" if it complicates your end of
the development process. Looks like devo's being able
to use automatic linking and the spread of that practice
will simplify all of our tasks.

I learned something to start by day and found out I had more power
that I thought. Could be a good day. May yours be better.

@armanbilge
Copy link
Member

Should really have a, voluntary, "Work started" label that is placed when someone "takes"
an item off the queue.

We can use "assignment" for that. Here, I will assign this issue to you :)

@LeeTibbert
Copy link
Contributor Author

Where it is OK to use self-assignment? I like that idea/practice.
@ekrich Can we loop you in on this discussion? What do you think?

  1. using auto-linking in the PR creation message

  2. voluntarily using "assignment" to "take a soft lock" when
    starting work in an Issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has pr There is a pending PR that addresses this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants