Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emitting single file when using LTO=none + release mode #3502

Closed
WojciechMazur opened this issue Sep 25, 2023 · 0 comments · Fixed by #3514
Closed

Remove emitting single file when using LTO=none + release mode #3502

WojciechMazur opened this issue Sep 25, 2023 · 0 comments · Fixed by #3514
Assignees
@tanishiking
Milestone
0.5.0

Comments

@WojciechMazur
Copy link
Contributor

The combination of LTO=none with release mode is emitting a single, enourmous file to allow for inlines at compile time. However, this performance hack, comes with a bad scaling when it comes to compilation times. Larger projects like our unit tests might take even +15 minutes just to compile.
We should remove the special handling of LTO=none + release mode and split the defs into N files to allow for faster, parallel compilation. We should also remove recently added warnings about using this combination of settings added in #3494
@WojciechMazur WojciechMazur added this to the 0.5.0 milestone Sep 25, 2023
tanishiking added a commit to tanishiking/scala-native that referenced this issue Sep 28, 2023
@tanishiking
Do not emit single LLVM IR file for release mode + LTO none
24d3b5c 
fix scala-native#3502

This performance hack seems to be introduced when
there's no LTO option is available in scala-native (or LLVM at that
time?)
scala-native#506
@tanishiking tanishiking mentioned this issue Sep 28, 2023
Merged
tanishiking added a commit to tanishiking/scala-native that referenced this issue Oct 1, 2023
@tanishiking
Do not emit single LLVM IR file for release mode + LTO none
5a4669b 
fix scala-native#3502

This performance hack seems to be introduced when
there's no LTO option is available in scala-native (or LLVM at that
time?)
scala-native#506
WojciechMazur pushed a commit that referenced this issue Oct 1, 2023
@tanishiking
Do not emit single LLVM IR file for release mode + LTO none (#3514)
7f9d75f 
fix #3502

This performance hack seems to be introduced when
there's no LTO option is available in scala-native (or LLVM at that
time?)
#506
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this issue Oct 4, 2023
@tanishiking @WojciechMazur
Do not emit single LLVM IR file for release mode + LTO none (scala-na…
495a895 
…tive#3514)

fix scala-native#3502

This performance hack seems to be introduced when
there's no LTO option is available in scala-native (or LLVM at that
time?)
scala-native#506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanishiking tanishiking

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Do not emit single LLVM IR file for release mode + LTO none tanishiking/scala-native
2 participants
@tanishiking @WojciechMazur