Resolve #1193 : Provide consistent project name pattern. #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densh
requested changes
Mar 12, 2018
build.sbt
Outdated
| // Provide consistent project name pattern. | ||
| lazy val nameSettings = Seq( | ||
| normalizedName := projectName(thisProject.value), // Maven <artifactId> | ||
| name := s"Scala.native ${projectName(thisProject.value)}" // Maven <name> |
There was a problem hiding this comment.
Scala Native is the official spelling, no dots.
| } | ||
|
|
||
| // Provide consistent project name pattern. | ||
| lazy val nameSettings = Seq( |
There was a problem hiding this comment.
This seems to belong to publishSettings. Lets put it there instead, then you don't have to add extra .settings(nameSettings) everywhere.
There was a problem hiding this comment.
applied to both publishSettings and noPublishSettings since there is no shared settings root in this build.sbt, which could cover all project modules
Andrei-Pozolotin
force-pushed
the
eclipse-project-name
branch
from
ce8e6d0
to
3538d1d
Compare
densh
requested changes
Mar 12, 2018
Andrei-Pozolotin
force-pushed
the
eclipse-project-name
branch
from
3538d1d
to
532d492
Compare
|
applied |
densh
approved these changes
Mar 23, 2018
|
LGTM, thanks @Andrei-Pozolotin ! |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1193 : Provide consistent project name pattern.