Resolve #1198: Fix FileChannel.read to have same semantics as JVM #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densh
requested changes
Mar 22, 2018
|
|
||
| var bread: Long = 0 | ||
|
|
||
| for (i <- start until number) { |
There was a problem hiding this comment.
Please use while loops instead of for comprehensions for performance-sensitive code.
| buffers(start + i).put(dst) | ||
| i += 1 | ||
|
|
||
| var bread: Long = 0 |
There was a problem hiding this comment.
Yeah, I thought it'd be a fun way to write bytesRead in way that enforces the correct reading of read (like "red", as opposed to "reed"). But I can change it.
There was a problem hiding this comment.
I looked at that too and said "what!". Then I figured maybe it was bytesRead but given your other short names it seemed out of place. I liked the 🍞 icon though. 😃
densh
approved these changes
Jul 3, 2018
|
LGTM, thanks @dlpatri! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala-Native's FileChannel.read operations were only reading a Byte at a time. The JVM's reads from the
ByteBuffer.position() until ByteBuffer.limit()or less, if there aren't that many bytes to read.Added/Changed/Fixed tests in FilesSuite and FileChannelSuite to accommodate the changes.