Fix BufferedInputStream.read() for values bigger than 0x7f #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Oct 7, 2020
Comment on lines
42
to
46
| val inputArray = Array[Byte](0x85.toByte) | ||
| val arrayIn = new ByteArrayInputStream(inputArray) | ||
| val in = new BufferedInputStream(arrayIn) |
There was a problem hiding this comment.
This is not correctly formatted according to scalafmt.
`read()` should return a value between `-1` and `255` and `-1` means `EOF`. When `buf(pos)` contains value bigger than `0x7f` for example `171.toByte` and makes `.toInt`, it converts this value to `-85` that can be regarded by enduser as `EOF` if he uses `< 0` condition. Unfortunately this bug hasn't got workaround on user side because when stream contains `0xff`, the `read()` returns `-1` and it is impossibly to distinguish the `EOF` and `0xff`.
catap
force-pushed
the
BufferedInputStream-read
branch
from
dd6b533
to
7bc78b4
Compare
sjrd
approved these changes
Oct 7, 2020
sjrd
changed the title
0x7f via BufferedInputStream
|
I was hoping that #1918 might be fixed by this but it isn't. Maybe a stream is reading passed the end of a buffer. @LeeTibbert I don't think your fixes would hurt either. |
vicopem
pushed a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…ive#1922) `read()` should return a value between `-1` and `255` and `-1` means `EOF`.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…cala-native#1922)" This reverts commit d4bbc6e.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…cala-native#1922)" This reverts commit d4bbc6e.
|
I was wrong. It is possibly to overstep this issue on The workaround: class ScalaNativeFriendlyBufferedInputStream(in: InputStream) extends BufferedInputStream(in) {
private val singleByte = new Array[Byte](1)
override def read(): Int = synchronized {
val r = read(singleByte)
if (r < 0) r
else singleByte(0).toInt & 0xff
}
} |
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
…ive#1922) `read()` should return a value between `-1` and `255` and `-1` means `EOF`.
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…ive#1922) `read()` should return a value between `-1` and `255` and `-1` means `EOF`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read()should return a value between-1and255and-1meansEOF.When
buf(pos)contains value bigger than0x7ffor example171.toByteand makes.toInt, it converts this value to-85that can be regarded by enduser asEOFif he uses< 0condition.Unfortunately this bug hasn't got workaround on user side because when stream contains
0xff, theread()returns-1and it is impossibly to distinguish theEOFand0xff.