Fix #2137: Two defects in j.n.PlainSocketImpl#read #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We correct two defects in the read method for java.net.PlainSocketImpl.
ekrich
reviewed
Feb 1, 2021
|
@ekrich Thank you for the review & suggestion. Both lead to the improvement of this submission. |
WojciechMazur
approved these changes
Feb 4, 2021
lolgab
reviewed
Feb 4, 2021
| bytesNum match { | ||
| case _ if (bytesNum > 0) => bytesNum | ||
|
|
||
| case _ if (bytesNum == 0) => if (count == 0) 0 else -1 |
There was a problem hiding this comment.
Suggested change
| case _ if (bytesNum == 0) => if (count == 0) 0 else -1 | |
| case 0 => if (count == 0) 0 else -1 |
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
…-native#2140) * Fix scala-native#2137: Two defects in j.n.PlainSocketImpl#read We correct two defects in the read method for java.net.PlainSocketImpl. * Incorporate review comment.
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…-native#2140) * Fix scala-native#2137: Two defects in j.n.PlainSocketImpl#read We correct two defects in the read method for java.net.PlainSocketImpl. * Incorporate review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We correct two defects in the read method for java.net.PlainSocketImpl.