Allow to run unit-tests on Windows #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekrich
reviewed
May 6, 2021
| // Windows specific copy of posixlib/time.h | ||
| // Uses *_s variants of methods instead of *_r | ||
| #if defined(_WIN32) | ||
| #define _CRT_SECURE_NO_WARNINGS |
There was a problem hiding this comment.
I really think we should consider just doing a clib time API - We should have virtually all the time stuff in clib and then just the posix specific in the posixlib.
Both time APIs can access the same C code and we could just deprecate most of the Scala in posixlib. You could then add just windows specific stuff in another interface as needed.
Do you think we should just address that in another PR and try it get it merged first?
WojciechMazur
force-pushed
the
windows/unit-tests
branch
from
4d50811
to
3e1c0ca
Compare
ekrich
reviewed
Jun 1, 2021
sjrd
requested changes
Jun 1, 2021
windowslib/src/main/scala/scala/scalanative/windows/util/Conversion.scala
Outdated
Show resolved
Hide resolved
windowslib/src/main/scala/scala/scalanative/windows/util/Conversion.scala
Outdated
Show resolved
Hide resolved
windowslib/src/main/scala/scala/scalanative/windows/util/HelperMethods.scala
Outdated
Show resolved
Hide resolved
WojciechMazur
force-pushed
the
windows/unit-tests
branch
from
ce35129
to
cd05441
Compare
WojciechMazur
force-pushed
the
windows/unit-tests
branch
from
cd05441
to
e75335e
Compare
sjrd
approved these changes
Aug 5, 2021
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
This PR continues topic of Scala Native support for Windows. It adds platform-specific compact layer for java.net Sockets allowing to execute unit tests. It also adds proper implementation for required java.io methods. To limit the number of changes currently only smaller subset of tests testsExt was added to CI * Included testsExt tests in the CI * Added minimal java.net implementation * Added binding for time.h not POSIX compliment *_s methods used in Windows * Added minimal java.io.File implementation required for tests * Added bindings for required WinSock2 and FileAPI functions * Fixed parsing symbols in Stacktrace on Windows * Added -g to compilation and linking step on Windows to allow gathering stack traces. * Fixed java.util.Date to compile on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues topic of Scala Native support for Windows. It adds platform-specific compact layer for
java.netSockets allowing to execute unit tests. It also adds proper implementation for requiredjava.iomethods. To limit the number of changes currently only smaller subset of teststestsExtwas added to CItestsExttests in the CIjava.netimplementationtime.hnot POSIX compliment*_smethods used in Windowsjava.io.Fileimplementation required for tests-gto compilation and linking step on Windows to allow gathering stack traces.java.util.Dateto compile on WindowsThis PR needs to be rebased onto #2281 to actually work.