Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2666: posix dirent constants are now parameterless methods #2668

Merged

Conversation

LeeTibbert
Copy link
Contributor

@LeeTibbert LeeTibbert commented Jun 21, 2022

This PR introduces a small source incompatibility so it needs to be on the 0.5.0 train.

Posixlib dirent.scala now follows the convention across Scala Native posixlib
that Posix C constants are Scala parameterless (zero-arity) methods.

@ekrich ekrich added this to the 0.5.0 milestone Jun 21, 2022
@ekrich
Copy link
Member

ekrich commented Jun 21, 2022

I set the 0.5.0 milestone if that is ok - I am thinking you want this merge post 0.4.x. It was mentioned that there might be one more release before breaking changes like 32bit and experimental multi-threading.

@LeeTibbert
Copy link
Contributor Author

re: I set the 0.5.0 milestone

Thank you. That makes my life easier.

I did not know that users could do that. Learn something every day.
I will have to check my other PRs intended for 0.5.0 to make sure that they
have that a "major ident change" milestone.

In case anybody wonders the obvious question:

I did a sweep through posixlib looking for posix constants as functions, i.e.
zero argument methods. dirent.scala was the only other file that needed
fixing. So, I think this PR completes the task.

@WojciechMazur WojciechMazur merged commit e31152c into scala-native:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants