Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build warning for macOS M1 #2732

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Remove build warning for macOS M1 #2732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/src/main/scala/scala/scalanative/build/NativeConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ sealed trait NativeConfig {

private lazy val detectedTriple = Discover.targetTriple(clang)

/** Are we targeting a 32-bit platform? */
/** Are we targeting a 32-bit platform?
*
* This should perhaps list known 32-bit architectures and search for others
* containing "32" and assume everything else is 64-bit. Printing the
* architecture for a name that is not found seems excessive perhaps?
*/
def is32BitPlatform = {
targetTriple
.getOrElse(detectedTriple)
Expand All @@ -64,6 +69,7 @@ sealed trait NativeConfig {
.getOrElse("") match {
case "x86_64" => false
case "aarch64" => false
case "arm64" => false
case "i386" => true
case "i686" => true
case o =>
Expand Down