Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2738: Shorten posixlib uio codepaths & add UioTest #2741

Merged

Conversation

LeeTibbert
Copy link
Contributor

This PR shortens the code paths for posixlib uio.scala scatter/gather methods readv & writev.
It implements UioTest.scala to verify that the shorter paths work as specified.

The creation of UioTest.scala provided the occasion to reorganize & consolidate SocketTestHelpers.scala,
UdpSocketTest.scala, and Udp6SocketTest.scala. This allows one implementation to be used
in a number of places. An upcoming socket.scala PR will be another user of this now common/shared
code.

@LeeTibbert LeeTibbert force-pushed the PR_posix_SysUioWritevReadv_I2738 branch from 12c615e to 16cb4f7 Compare July 20, 2022 04:25
@LeeTibbert LeeTibbert force-pushed the PR_posix_SysUioWritevReadv_I2738 branch from 16cb4f7 to c929434 Compare July 24, 2022 13:05
@LeeTibbert
Copy link
Contributor Author

Re-based & passing, modulo usual qemu errors.

I am told that in Japanese zen sand gardens it is
traditional to leave a small imperfection so that one
can appreciate the perfection of the remainder of
the garden. When I get (beyond) frustrated
by the apparently spurious qemu failures, I
try to get in touch with that concept.

@WojciechMazur WojciechMazur merged commit dd7bc81 into scala-native:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants