New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove URL stubs for 0.5.0 #2788
Conversation
@WojciechMazur This is ready for review. |
Eric, what offering did you give to You must be leading a more virtuous life than I and |
The Do you have thoughts of where you would like to see a "Deprecations" section? |
I just copied the 0.4.0 file because it was the last major release with lots of changes. We should maybe put removed deprecations in the breaking section and if we have new ones then maybe a new deprecation section. |
re: removed & new deprecation items. Sounds good to me. Do you want to drop in those headers where you think they should go so that they A thought. |
It is not said often enough or by enough people, but thank you for your housekeeping and supervision |
I've created a repo with to-be-removed methods, can to you take a look does it contain all removed interfaces? Also, I've seen that probably some of the URI or URL-related classes might be not removed, was that expected? |
I think the original intent was to have a place for the security code but that is more tangled than expected so far. |
75c06a8
to
26db20b
Compare
@WojciechMazur This is ready for review. Might go first as it adds the 0.5.0 release notes that we can add to in subsequent PRs. |
26db20b
to
2e81c9f
Compare
2e81c9f
to
36f8fab
Compare
This PR removes
java.net.URL
and friends and alsojava.net.URI.toURL
. It is important to do these removals as soon as possible in these breaking releases to give downstream application a chance to adapt. Also, removing them now with no deprecation cycle is better to avoid future people from relying on the code while we have less adoption and more motivated adopters.URL stubs were added to support https://github.com/ekrich/sconfig which is an important dependency for a Scala Native version of
scalafmt
. Other libraries may have been relying on them too.Because URL is basically a full HTTP client library, it is non-trivial to implement. It is not implemented in Scala.js because it is not possible due to concurrent DNS lookups and Scala Native also supports a single threaded runtime, so we should not add it to the base system.
A release file was added using the last major release as a template. This was needed to capture the details.