Fix #2911: javalib IPv6 addresses now display using only lowercase hexadecimal digits #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e hexadecimal digits
LeeTibbert
added
component:javalib
backport candidate
|
This PR is ready for review & merge. Thank you for considering it. The three build failures have nothing to do with the change of this PR. |
|
This PR will make it easier for me & others to write unit-tests which match ScalaJVM. |
|
3 build failures reviewed. Network connection failures, not related to the substance of this PR. I believe this PR is ready for review & merge. Thank you. |
WojciechMazur
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2911
When javalib displays an IPv6 address it now matches the JVM output, e.g. "fe80::mumble".
The content of this PR is a candidate for porting to the 0.4.x stream. Because of the
restructuring in merged 0.5.0 PR #2877, backporting this PR should probably happen
after #2877 is backported.