Fix 2980: javalib j.l.p.UnixProcessGen2 now spawns when it can. #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2980
Javalib java.lang.process.UnixProcessGen2.apply() now spawns when it can, just like a salmon or trout.
Using
ProcessBuilder.directory(newDirectory)to specify a new working directory will cause fallback tothe legacy
fork()code.Process spawn is recommended by macOS >= 12.0 as the replacement for
the now entirely removed
vfork()syscall. On Linux, spawn should be marginallyfaster & less system resource hungry than
fork().End users should see no functional change beyond, possibly, an improvement in execution speed.