Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix #2765: Remove long deprecated declaration in ScalaNativePlugin #3004

Conversation

LeeTibbert
Copy link
Contributor

PR #2783 removed a long deprecated declaration in ScalaNativePlugin.scala. For reasons
at the time, it was never merged. However changelog/0.5.0.md was changed to note
the deprecation.

This PR removes that deprecated declaration. There is no need to update the documentation.

@LeeTibbert
Copy link
Contributor Author

When I updated changelog/0.5.0.md weeks ago, I did not create a "suggested replacement" line
because the original deprecation message made no sense at all to me and I did not have
the patience to go diving into long obsolete sbt practice.

@deprecated("use autoImport instead", "0.3.7")
  val AutoImport = autoImport

Note the case differences.

If anyone can suggest text for a sensible "Suggested replacement" section, I can update the changelog.
By now, anybody using the deprecated declaration (or the "use..." text") is probably long retired.

@WojciechMazur
Copy link
Contributor

I don't think any suggested replecement is really needed. Usage of autoImport object is a standard behavior in most of the sbt plugins.

@WojciechMazur WojciechMazur merged commit c49d875 into scala-native:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants