Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clib traits private #3038

Merged
merged 1 commit into from Dec 20, 2022
Merged

Make clib traits private #3038

merged 1 commit into from Dec 20, 2022

Conversation

LeeTibbert
Copy link
Contributor

Traits in clib are now a private implementation detail.

@LeeTibbert
Copy link
Contributor Author

This is the resolution of the discussion in PR #3034, per Wojciech's recommendation/direction.

@LeeTibbert
Copy link
Contributor Author

clib tgmath.scala had a simple public trait, no "@extern". There seemed to be no
good reason to leave it public so, in the spirit of things, I made it private also.

I point this out to reviewers so that the unique change does not get lost in the
mass of regular @extern changes.

@LeeTibbert LeeTibbert mentioned this pull request Dec 14, 2022
Merged
@WojciechMazur WojciechMazur merged commit 0051bc1 into scala-native:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeeTibbert @WojciechMazur