tidy: replace apply() with empty to avoid allocation #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i10416
force-pushed
the
opt-replace-apply-with-empty
branch
2 times, most recently
from
0c07f89
to
bdb0318
Compare
i10416
force-pushed
the
opt-replace-apply-with-empty
branch
from
bdb0318
to
c6d9364
Compare
|
could someone re-run the test that failed due to 503 Service Unavailable? |
WojciechMazur
approved these changes
Jan 10, 2023
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Jan 26, 2023
(cherry picked from commit b4f266b)
WojciechMazur
pushed a commit
that referenced
this pull request
Jan 27, 2023
(cherry picked from commit b4f266b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract the lowest-hanging fruits from #3067; just small micro-optimization
I feel this kind of chores should be done by Scalafix馃