Handle concurrent initialization of modules #3124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the module accessors (Scala's
object
defining at least 1 field) is not aware of multithreading. It can end up in multiple initializations ofmodule
, or returning not fully initialized object.This change adds a synchronized version of module accessors using the non-locking mechanism for the synchronization of threads. It comes with a higher overhead than the legacy version, so compilation with disabled multithreading would use the old mechanism.
A new technique due to higher complexity is implemented in
C
instead of plainNIR
structures.*An uninitialized module is
null
as null in themodules
array.( Upon the first load of the module, we can observe
null
and make acompare and swap
operation setting the module value to the Initialization state which is a pointer to the structure containing intermediate data (eg. address of allocated object).