Fix #3206: posixlib unistd and monetary use new CVarArgs support #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
approved these changes
Mar 10, 2023
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Mar 14, 2023
WojciechMazur
pushed a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3206
Two posixlib files now use the new CVarArgs (...) support.
unistd.scalanow defines threepreviously missing
execl*()methods. Workaround code was removed frommonetary.scala.Backport: This PR depends upon, and owes a debt of gratitude to, PR #3204. If that PR
gets backported, then this PR becomes eligible for backport.
Testing:
MonetaryTestpasses.All of the posixlib
exec*()methods are difficult to test in the SNunit-testsenvironment.I wrote a small private program to exercise
execlbefore I submitted this PR. It passes.Later: To quell my anxieties, I extended this private program to additionally exercise both
execlpand
execle. Now all three pass locally.