-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Array[Int]
instead of Array[Array[Boolean]]
for [class,trait]_has_trait
#3279
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fb93eb3
WIP: Efficient trait_has_trait
lolgab d55264e
It links now
lolgab 7850cfe
Cleanup code
lolgab d2aff25
Basic usage works
lolgab 34979a7
Use the right table
lolgab dc28a54
Fix compilation on Scala 3
lolgab 51853bf
Run Scalafmt
lolgab 93716f8
Avoid making Impl object public
lolgab 4bedc6d
Rephrase genHasTrait comment
lolgab 5ff3320
DRY genHasTrait a bit
lolgab 852bea5
Use Array[Int] instead of Array[Long] for matrices
lolgab File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
tools/src/main/scala/scala/scalanative/codegen/BitMatrix.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package scala.scalanative | ||
|
||
private[scalanative] class BitMatrix private ( | ||
bits: Array[Int], | ||
columns: Int | ||
) { | ||
import BitMatrix.{AddressBitsPerWord, ElementSize, RightBits} | ||
|
||
def set(row: Int, col: Int): Unit = { | ||
val bitIndex = row * columns + col | ||
bits(bitIndex >> AddressBitsPerWord) |= 1 << (bitIndex & RightBits) | ||
} | ||
|
||
def toSeq = bits.toSeq | ||
} | ||
private[scalanative] object BitMatrix { | ||
private[scalanative] final val AddressBitsPerWord = 5 // Int Based 2^5 = 32 | ||
private[scalanative] final val ElementSize = 1 << AddressBitsPerWord | ||
private[scalanative] final val RightBits = ElementSize - 1 | ||
|
||
def apply(rows: Int, columns: Int): BitMatrix = { | ||
val nbits = rows * columns | ||
val length = (nbits + RightBits) >> AddressBitsPerWord | ||
new BitMatrix(new Array[Int](length), columns) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minimal version of our java BitSet implementation with fixed size and no bound checks.
It represents a matrix so it calculates the array index storing the matrix by rows.