Character.isWhitespace(-1) returns false #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix scala-native#3154 Previously, `Character.isWhitespace(-1)` and `Character.isLowerCase(-1)` throw `java.lang.ArrayIndexOutOfBoundsException: -1`. However, they should return `false` as other java std libraries do. We may want to fix `getTypeLT256`, but this commit guaranteed that the codepoint is gte 0 on call-site of `getTypeLT256` for not introducing the duplicated check of `codePoint < 0`.
|
This looks good. It might be a good idea to check Scala.js as well. We like to try and uses the same tests on both and either create an issue or PR in Scala.js too. |
WojciechMazur
approved these changes
May 15, 2023
WojciechMazur
pushed a commit
that referenced
this pull request
May 23, 2023
Fix #3154 Previously, `Character.isWhitespace(-1)` and `Character.isLowerCase(-1)` throw `java.lang.ArrayIndexOutOfBoundsException: -1`. However, they should return `false` as other java std libraries do. We may want to fix `getTypeLT256`, but this commit guaranteed that the codepoint is gte 0 on call-site of `getTypeLT256` for not introducing the duplicated check of `codePoint < 0`. (cherry picked from commit f71420c)
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 5, 2023
Fix #3154 Previously, `Character.isWhitespace(-1)` and `Character.isLowerCase(-1)` throw `java.lang.ArrayIndexOutOfBoundsException: -1`. However, they should return `false` as other java std libraries do. We may want to fix `getTypeLT256`, but this commit guaranteed that the codepoint is gte 0 on call-site of `getTypeLT256` for not introducing the duplicated check of `codePoint < 0`. (cherry picked from commit f71420c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3154
Previously,
Character.isWhitespace(-1)andCharacter.isLowerCase(-1)throwjava.lang.ArrayIndexOutOfBoundsException: -1.However, they should return
falseas other java std libraries do.We may want to fix
getTypeLT256, but this commit guaranteed that the codepoint is gte 0 on call-site ofgetTypeLT256for not introducing the duplicated check ofcodePoint < 0.