javalib WindowsPath fixes + unit tests #3299
Conversation
… a root for DriveRelative and DirectoryRelative paths
Tests are based on UnixPathTest with modifications and additions to for Windows paths. Tests were verified by running them vs JVM on Windows. Some additional tests are commented out to mark known issues and help with future development.
|
Thank you! So far looks good. |
Added IDs, so it is possible to identify which assertion is failing just from the test output.
|
Disabling selected assertions on JVM8 should be working correctly now |
|
I will not have time to look at the TODOs in a short term. This PR was primarily to address #3293. I resolved that and addressed a few other issues with WindowsPath in this PR too. The commented tests marked with TODO identified additional issues with WindowsPath beyond #3293. I left the comments in rather than deleted them to help whoever will be looking at this later. You may want to create a separate issue for that. I may be able to address them in the future, cannot promise specific time. I am working on a project that is using Scala Native: https://github.com/ij-plugins/ijp-imagej-launcher, it drives my time priorities, currently, till I get the main features implemented. That's were #3293 was discovered. If run in some other issue there I will report and help fixing if I can. For instance, I may need #266 or a workaround eventually, but that issue is opened for a long time and I am not clear how it could be addressed. |
* WindowsPath: Correct detection of the path type and the extraction of a root for DriveRelative and DirectoryRelative paths * WindowsPath: Correct parent extraction, consider DirectoryRelative * WindowsPath: Correct path creation in `relativize` * WindowsPath: Empty path's type should be Relative * [WIP] `relativize` should throw exceptions on invalid input * WindowsPath: add unit tests Tests are based on UnixPathTest with modifications and additions to for Windows paths. Tests were verified by running them vs JVM on Windows. Some additional tests are commented out to mark known issues and help with future development. * WindowsPath: better switching of tests on JVM 8; add assertion IDs Added IDs, so it is possible to identify which assertion is failing just from the test output.
* WindowsPath: Correct detection of the path type and the extraction of a root for DriveRelative and DirectoryRelative paths * WindowsPath: Correct parent extraction, consider DirectoryRelative * WindowsPath: Correct path creation in `relativize` * WindowsPath: Empty path's type should be Relative * [WIP] `relativize` should throw exceptions on invalid input * WindowsPath: add unit tests Tests are based on UnixPathTest with modifications and additions to for Windows paths. Tests were verified by running them vs JVM on Windows. Some additional tests are commented out to mark known issues and help with future development. * WindowsPath: better switching of tests on JVM 8; add assertion IDs Added IDs, so it is possible to identify which assertion is failing just from the test output.
* WindowsPath: Correct detection of the path type and the extraction of a root for DriveRelative and DirectoryRelative paths * WindowsPath: Correct parent extraction, consider DirectoryRelative * WindowsPath: Correct path creation in `relativize` * WindowsPath: Empty path's type should be Relative * [WIP] `relativize` should throw exceptions on invalid input * WindowsPath: add unit tests Tests are based on UnixPathTest with modifications and additions to for Windows paths. Tests were verified by running them vs JVM on Windows. Some additional tests are commented out to mark known issues and help with future development. * WindowsPath: better switching of tests on JVM 8; add assertion IDs Added IDs, so it is possible to identify which assertion is failing just from the test output.
I added unit tests for javalib WindowsPath, fixed #relativize (#3293 and other issues), and couple of other errors in WindowsPath that were discovered with new the unit tests.
The unit tests are based on UnixPathTest with additions for drive letters on Windows. The assertions were tested by running tests on Java VM Windows.
While number of issues were fixed, there are a couple remaining. Unit tests for those issues are commended out and marked with
TODO, to help with future work. I am running out of time I can spent on this currently, but WindowsPath should be in a better shape than it was before.