Port ConcurrentNavigableMap.java from JSR-166
#3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
64
to
65
| * <p>The returned map has an ordering equivalent to {@link | ||
| * java.util.Collections# reverseOrder ( Comparator ) |
There was a problem hiding this comment.
Scalafmt does not work well with JavaDoc comments - because the {@link java.util.Collections#} is spanned across multiple lines Scaladoc would fail to build it. In most of JSR166 stuff (e.g. ForkJoinPool) javadoc comments were completely removed because of multiple issues related to that. Alternative is to use ScalaDoc syntax using brackets, however in case of JavaLib we can just get rid of documentation.
We still have official documentations, which would be typically used, while our generation of javadocs could be mostly used to compare which classess/methods are available in our implementation.
There was a problem hiding this comment.
thanks, I omitted document in 4d6911c.
WojciechMazur
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from jsr166 (revision 1.20).
ConcurrentNavigableMapis required forConcurrentSkipListMap.