Fix #3329: javalib MappedByteBufferImpl no longer calls FileChannel truncate method #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTibbert
added
component:javalib
os:macos
os:linux
backport candidate
ekrich
reviewed
Jun 22, 2023
Comment on lines
+313
to
+319
| val channel = FileChannel.open( | ||
| f, | ||
| StandardOpenOption.READ, | ||
| StandardOpenOption.WRITE | ||
| ) | ||
|
|
||
| try { |
There was a problem hiding this comment.
You could use Using to manage the resource here rather than try, finally. https://www.scala-lang.org/api/2.13.6/scala/util/Using$.html
There was a problem hiding this comment.
Eric,
Thank you for the suggestion. This code needs to also run on Scala 2.12.n.
I believe that Using is not available for that Scala version. `Tis a pity,
the Using idiom is much closer to the Java try-with-resources idiom.
Did I miss something in Scala 2.12?
There was a problem hiding this comment.
I guess it is added in Scala Collection Compat but I don't think we want to add that. - https://github.com/scala/scala-collection-compat/tree/main/compat/src/main/scala-2.12/scala/util :-(
WojciechMazur
approved these changes
Jun 29, 2023
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
…ileChannel truncate method (scala-native#3345) * Fix scala-native#3329: javalib MappedByteBufferImpl no longer calls truncate method * Change Exception message to match a JVM (cherry picked from commit 4687be0)
WojciechMazur
added a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3329
Credit:
Aly on Scala Native Discourse gave invaluable information on how Windows extends files.
Any defects from misinterpretation of that information fall on this Author.
Changes
javalib
MappedByteBufferImplno longer callsFileChannel#truncateto extend files.The latter method is defined as never extending a file, so the former method calling
the latter was a defect.
This is primarily an internal re-organization which prepares the ground for correcting the more
visible and impactful Issue #3330.
A keen user may detect three user visible changes.
IllegalArgumentExceptionwas changed to match (a, not every) JVM.