Fix #3308, #3350: better reporting of javalib stream & spliterator characteristics #3354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix javalib ArrayList#spliterator should report ORDERED characteristic. #3350: spliterator returned by javalib
ArrayList#spliterator
now matches a JVM by reporting theORDERED characteristic.
Fix javalib BaseStream.unordered() method is hard broken. #3308: the javalib stream returned by the
unordered
method onStream
orDoubleStream
with an ORDERED stream argument now returns characteristics matching a JVM. ORDERED
is not present. Only the DISTINCT and SORTED characteristics, if present, are passed along to
the new stream.
The first fix is used to test the second fix and visa versa.
Note: The spliterator returned by
ArrayList#spliterator
now binds later, as part of the firsttryAdvance()
. No attempt is made to detectConcurrentModification
, but the laterbinding should narrow the window of vulnerability. Here "Best Effort" is zero effort.