Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3340: javalib MappedByteBuffer now handles 0 byte ranges #3360

Merged
merged 1 commit into from Jun 30, 2023
Merged

Fix #3340: javalib MappedByteBuffer now handles 0 byte ranges #3360

merged 1 commit into from Jun 30, 2023

Conversation

LeeTibbert
Copy link
Contributor

Fix #3340

JVM allows FileChannel#map to map zero sized ranges. Scala Native now does the same.

@LeeTibbert LeeTibbert added component:javalib backport candidate PR which might be backported into previous major release of SN labels Jun 30, 2023
@LeeTibbert
Copy link
Contributor Author

The one failing test appears to have nothing to do with the substance of this PR.
Everything else is Green.

The failure is in a Windows JDK compliance test, where sbt fails on startup:

[info] [launcher] getting org.scala-sbt sbt 1.9.0  (this may take some time)...
[info] [launcher] getting Scala 2.12.18 (for sbt)...
sbt.internal.ServerAlreadyBootingException: java.io.IOException: Could not create lock for \\.\pipe\sbt-load-5475876620823648645_lock, error 998
sbt thinks that server is already booting because of this exception:
	at sbt.internal.BootServerSocket.newSocket(BootServerSocket.java:356)

@WojciechMazur WojciechMazur merged commit 594e24f into scala-native:main Jun 30, 2023
77 checks passed
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this pull request Sep 1, 2023
@LeeTibbert @WojciechMazur
Fix scala-native#3340: javalib MappedByteBuffer now handles 0 byte ra…
f429a8f 
…nges (scala-native#3360)

(cherry picked from commit 594e24f)
WojciechMazur pushed a commit that referenced this pull request Sep 4, 2023
@LeeTibbert @WojciechMazur
Fix #3340: javalib MappedByteBuffer now handles 0 byte ranges (#3360)
96bb1a1 
(cherry picked from commit 594e24f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

Assignees
No one assigned
Labels
backport candidate PR which might be backported into previous major release of SN component:javalib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

javalib MappedByteBuffer fails or succeeds too well when mapping zero bytes.
2 participants
@LeeTibbert @WojciechMazur