Implement scala.scalanative.annotation.align annotation, replacement for JVM @Contended
#3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to expected width in bytes. It also does allow to group fields simillary as JVM Contended annotation. Allows for fixed size alignment or platform-specific linkime resolved alignment width
WojciechMazur
force-pushed
the
feature/fields-alignment
branch
from
275b07b
to
eea08d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3359
Implements new public annotation allowing to modify alignment of the fields. It is source-compatible with the JVM Contaned annotation, and have similar characteristics.
@align(size: Int, group: String)takes the fixed size of alignment in bytes and group name allowing to coalate fields. Whensizeis not passed or when pointing toscalanative.meta.LinktimeInfo.contendedPaddingWidthit would use linktime resolved value instead (default to 64 bytes, the most popular cache line size on modern architectures). This allows to use it as a direct replecment for Contended, which cannot be implemented in Scala Native directly.