Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3316: javalib FileChannel append behavior now matches a JVM #3368

Conversation

LeeTibbert
Copy link
Contributor

Fix #3316

javalib FileChannel write & position methods now more closely match JVM behavior.

@LeeTibbert LeeTibbert added component:javalib backport candidate PR which might be backported into previous major release of SN labels Jul 3, 2023
@LeeTibbert
Copy link
Contributor Author

End of session: 1 build error. I will check for other build errors next session.

To the tune of "It ain't me, babe":

" Run tests Windows / Test experimental multithreading support (3, debug, boehm, none) (pull_request) Failing after 17m"

"""
[error] Test org.scalanative.testsuite.javalib.lang.ObjectMonitorTest.keeps recursions track after wait when already inflated failed: java.lang.AssertionError: done, took 3.603 sec
[error] at java.lang.StackTrace$.currentStackTrace$$anonfun$1(Unknown Source)
[error] at java.lang.StackTrace$$$Lambda$2.applyVoid(Unknown Source)
[error] at scala.runtime.function.JProcedure1.apply(Unknown Source)
[error] at scala.scalanative.unsafe.Zone$.apply(Unknown Source)
[error] at java.lang.StackTrace$.currentStackTrace(Unknown Source)
[error] at java.lang.Throwable.fillInStackTrace(Unknown Source)
"""

@WojciechMazur WojciechMazur merged commit 014f0ad into scala-native:main Jul 3, 2023
76 of 77 checks passed
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this pull request Sep 1, 2023
WojciechMazur pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport candidate PR which might be backported into previous major release of SN component:javalib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot append to a ByteChannel
2 participants