Fix #3309: javalib stream limit methods now match Java 8 #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTibbert
added
component:javalib
backport candidate
|
Interesting failure: failed Check CLA. Time to renew my subscription and/or bona fides, I guess. |
WojciechMazur
approved these changes
Jul 17, 2023
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
…cala-native#3390) * Fix scala-native#3309: javalib stream limit methods now match Java 8 * Fix OR syntax for Scala 2 * Address second round of Scala 2 type issues * limit() tests should use known AnyRef, not spooky conversions (cherry picked from commit eb2caf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3309
The
limit()methods in javalib Stream and DoubleStream classes now match the size and characteristicsreported by Java 8.
Please note well that sometime at least by Java 17, the behavior of those methods changed for
parallel ORDERED streams. The Java 17+ behavior is incompatible with Java 8.
Scala Native javalib describes itself as Java 8 (1.8). The behavior implemented here matches
that description but is likely to annoy people porting Java 17+ code to Scala Native.
Please see the Issue for a longer discussion.
The fix in this PR required making the
sorted()methods return characteristicswhich better match a JVM.