Add partial implementation of java.util.EnumSet #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jul 19, 2023
| @@ -2,27 +2,113 @@ package java.util | |||
|
|
|||
| import java.lang.Enum | |||
|
|
|||
| final class EnumSet[E <: Enum[E]] private (values: Array[E]) | |||
| final class EnumSet[E <: Enum[E]] private (values: Set[E]) | |||
There was a problem hiding this comment.
this could still be an array where the index corresponds to ordinal, and the max ordinal + 1 is the size of the array? (never shrink, only grow by powers of 2?)
There was a problem hiding this comment.
Sure, it could have been, but it's not going to be frequently used, and that way we get the Set ops for free. At some point it could be rewriten to be more optimal, but for current usages its good enough, especially since we cannot support the relection based semantics to populate it with all values
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
(cherry picked from commit ce94cf5)
WojciechMazur
added a commit
that referenced
this pull request
Sep 4, 2023
(cherry picked from commit ce94cf5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple implementation of EnumSet for parts not requiring reflection support.
Resolves #3385