Detect block cycles using stackalloc op #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of inlined, potentially looped functions
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
* Detect block cycles using stackalloc to improve stack memory managment of inlined, potentially looped functions * Fix issue with reseting state upon assigning memory to variable and though escaping the loop. * Ensure the stackrestore target exists. Fixes issues found in release mode (cherry picked from commit 3273166)
WojciechMazur
added a commit
that referenced
this pull request
Sep 4, 2023
* Detect block cycles using stackalloc to improve stack memory managment of inlined, potentially looped functions * Fix issue with reseting state upon assigning memory to variable and though escaping the loop. * Ensure the stackrestore target exists. Fixes issues found in release mode (cherry picked from commit 3273166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect block cycles using stackalloc to improve stack memory managment of inlined, potentially looped functions.
Previously, we've emitted a StackSave/Restore LLVM intrinnsics every time inlined code contained Op.Stackalloc instructions. These however where not required, when inlined code, was never part of a loop. Also in the past multiple subsequent inlines created multiple StackSave/Restore instructions leading to potentiall performance penalty.
This change adds detection of cycles and stackallocation in MergeBlocks. Based on them we create exactly 1 StackSave operation at the entry of the loop, and exactly 1 StackRestore before each jump to block marked as start of loop.