Evolve new javalib StringJoiner class #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTibbert
added
component:javalib
backport candidate
…lation to succeed
WojciechMazur
approved these changes
Aug 9, 2023
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
* Evolve javalib StringJoiner class * javalib should use Java, not Scala StringBuilder; allows Java 8 compilation to succeed (cherry picked from commit c4e9c81)
WojciechMazur
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Evolve javalib StringJoiner class * javalib should use Java, not Scala StringBuilder; allows Java 8 compilation to succeed (cherry picked from commit c4e9c81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the internals of the recently merged javalib
StringJoinerclass with the goals ofreducing resource usage and improving execution speed.
The Tests of merged PR #3396 are used unchanged to verify that the evolved code implement
the StringJoiner API correctly.