Better handling of uncaught exceptions in main and user threads #3423
Conversation
|
Suggested change in title: s/uncought/uncaught/ |
There was a problem hiding this comment.
It looks good to me, now we will have
Exception in thread "main"
Exception: java.lang.StringIndexOutOfBoundsException thrown from the UncaughtExceptionHandler in thread "main"
... (stacktrace)
when exception is thrown while rendering another exception 👍
I left one question about setDefaultUncaughtExceptionHandler.
|
|
||
| // ScalaNativeSpecific exception handler, used when executing user-provied handlers, in main | ||
| // Duplicate in NativeThread.threadEntryPoint | ||
| private[java] final def uncaughtExceptionInternal( |
There was a problem hiding this comment.
[note] We come here when scala-native app fails with uncaught exception
| try uncaughtException(t, e) | ||
| catch { |
There was a problem hiding this comment.
[note]
here we catch the exception thrown while rendering another exception
| def getDefaultUncaughtExceptionHandler(): UncaughtExceptionHandler = | ||
| defaultExceptionHandler | ||
| def setDefaultUncaughtHandler(eh: UncaughtExceptionHandler): Unit = | ||
| def setDefaultUncaughtExceptionHandler(eh: UncaughtExceptionHandler): Unit = |
There was a problem hiding this comment.
Maybe a silly question, who calls setDefaultUncaughtExceptionHandler? I couldn't find the caller of this method in this project, and ThreadGroup#uncaughtException always goes this branch
scala-native/javalib/src/main/scala/java/lang/ThreadGroup.scala
Lines 222 to 225 in ac2460c
There was a problem hiding this comment.
Nevermind, it's gonna be used by users like Thread.setDefaultUncaughtExceptionHandler(new MyExceptionHandler());
Not just in the title, some places in the code also mention |
WojciechMazur
changed the title
…Thread.UEH, move logic to nativelib
Fixes #3418