Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2731: Need better way to detect 32-bit platforms #3436

Merged
merged 3 commits into from Aug 17, 2023

Conversation

ekrich
Copy link
Member

@ekrich ekrich commented Aug 16, 2023

Thanks to the previous work on TargetTriple - #3258

Now we should be technically able to support all 32 bit and 64 bit with only "unknown" for 16 bit and unknown. At least there are no restrictions.

@LeeTibbert
Copy link
Contributor

LGTM - Looks good to me.

Thank you for pulling one more thorn out of our collective paw.

Having to hard code the list of architectures is probably the best we can economically
do at this point. At least you found an authoritative source.

@ekrich
Copy link
Member Author

ekrich commented Aug 17, 2023

Having to hard code the list of architectures is probably the best we can economically
do at this point. At least you found an authoritative source.

These are actually the architecture categories. Every architecture is covered in the parsing and there are many more. Parsing was the hard part which was done thankfully. There was only one category that was not an architecture as well and that was x86. You can see that in the test with the i386 as the example that parses to the x86 category.

@WojciechMazur WojciechMazur merged commit 2ae4071 into scala-native:main Aug 17, 2023
79 checks passed
@ekrich ekrich deleted the topic/is32bit branch August 17, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants