Fixing Bug in Lowering: Handling Op.Copy for ClassOf Transformation #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix scala-native#3442 Previously, we didn't exhaustiely Prior to this change, there was an issue in the lowering process where the value of `Op.Copy` was not being appropriately adjusted during the lowering procedure. This issue became clear when attempting to lower a value represented as `Val.ClassOf` For instance, the transformation of `ClassOf(Top(scala.scalanative.runtime.DoubleArray))` needed to be lowered to `Global(Member(Top(scala.scalanative.runtime.DoubleArray), G4type), Ptr)`. However, this transformation was failing with the error message 'Lowering ClassOf needs nir.Buffer' because the value represented by `Val.ClassOf` was not being properly lowered, especially with `SCALANATIVE_OPTIMIZE=false`.
WojciechMazur
approved these changes
Aug 24, 2023
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
…cala-native#3447) fix scala-native#3442 Previously, we didn't exhaustiely Prior to this change, there was an issue in the lowering process where the value of `Op.Copy` was not being appropriately adjusted during the lowering procedure. This issue became clear when attempting to lower a value represented as `Val.ClassOf` For instance, the transformation of `ClassOf(Top(scala.scalanative.runtime.DoubleArray))` needed to be lowered to `Global(Member(Top(scala.scalanative.runtime.DoubleArray), G4type), Ptr)`. However, this transformation was failing with the error message 'Lowering ClassOf needs nir.Buffer' because the value represented by `Val.ClassOf` was not being properly lowered, especially with `SCALANATIVE_OPTIMIZE=false`. (cherry picked from commit 4c4006c)
WojciechMazur
pushed a commit
that referenced
this pull request
Sep 4, 2023
…3447) fix #3442 Previously, we didn't exhaustiely Prior to this change, there was an issue in the lowering process where the value of `Op.Copy` was not being appropriately adjusted during the lowering procedure. This issue became clear when attempting to lower a value represented as `Val.ClassOf` For instance, the transformation of `ClassOf(Top(scala.scalanative.runtime.DoubleArray))` needed to be lowered to `Global(Member(Top(scala.scalanative.runtime.DoubleArray), G4type), Ptr)`. However, this transformation was failing with the error message 'Lowering ClassOf needs nir.Buffer' because the value represented by `Val.ClassOf` was not being properly lowered, especially with `SCALANATIVE_OPTIMIZE=false`. (cherry picked from commit 4c4006c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3442
Previously, we didn't exhaustiely
Prior to this change, there was an issue in the lowering process where the value of
Op.Copywas not being appropriately adjusted during the lowering procedure. This issue became clear when attempting to lower a value represented asVal.ClassOfFor instance, the transformation of
ClassOf(Top(scala.scalanative.runtime.DoubleArray))needed to be lowered toGlobal(Member(Top(scala.scalanative.runtime.DoubleArray), G4type), Ptr).However, this transformation was failing with the error message 'Lowering ClassOf needs nir.Buffer' because the value represented by
Val.ClassOfwas not being properly lowered, especially withSCALANATIVE_OPTIMIZE=false.