Detect at linktime usage of unsupported features #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception at runtime
|
@natsukagami It can be used later to guard against usage of delimited continuations on Windows. It would be great to add 1 more unsupported feature for continuations instead of reusing virtualThreads category. |
…be eliminated due to creation of MainThread. Use guard only when starting os thread
WojciechMazur
deleted the
feature/detect-usage-of-unsupported-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to detect usage of unsupported features early at linktime based of linktime-resolved conditions.
Thanks to this feature, we can guard against of runtime failures for some well known execution flows. One of them is running Thread with disabled multithreading support.
By defining
scala.scalanative.runtime.UnsupportedFeatureas Java file it would never contain NIR. We can collect it's usages and adapt them to present more user friendly messages.