New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3477: javalib Channels.newChannel#read now reports EOF #3478
Fix #3477: javalib Channels.newChannel#read now reports EOF #3478
Conversation
0eb6664
to
56f8eda
Compare
The four failures seem to have nothing to do with the changes of this PR. At least two are When he day cools off and I can get back to my work machine, I will roll this up the hill and drop it again. |
The two failures appear to have nothing to do with the changes of this PR.
My time is quite limited for the rest of the week. I will chase the |
There are some guards in the system for that call but they must not be sufficient. I am not sure why we are using these Linuxisms unless we have to as it decreases portability and maintainability. |
The OS specific code is because process control tends to be OS specific. Linux has one way, I think Logically, the presence or absence of an operating system entry point should not depend on whether Of course, this "feature" does not show itself on either my Linux or macOS system (or else My rough plan is to create a Draft/WIP PR which:
Unfortunately, as mentioned, my debug time is limited for the next week or so. This kind of work can In my first few runs through this, I did not see any differences in how the succeeding & failing |
From WIP PR #3480 and a CI run in my fork, it looks like this is becoming more consistently Now if someone could give me 72 hour energetic, productive hours in a day.... |
…OF (scala-native#3478) * Fix scala-native#3477: javalib Channels.newChannel#read now reports EOF * Restart CI; no semantic changes (cherry picked from commit f50d68d)
Fix #3477
The
read()
method returned by javalibChannels.newChannel
now reports end of file (a.k.a EOF)as described in the corresponding JDK
ReadByteChannel
documentation (-1).