Allow to build Scala Native on JDK 21 #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, and is only available in JDK 19-20 until --preview flag. Remove it's implementation and tests referencing this no longer existing API
…est JDK versions
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 4, 2023
* `Thread.Builder.allowSetThreadLocals` didn't made it to stable release, and is only available in JDK 19-20 until --preview flag. Remove it's implementation and tests referencing this no longer existing API * Update CI to test against JDK 21 instead of JDK 20 with --enable-preview flags * Don't warn when accessing `Thread.getId()` which is deprecated in latest JDK versions * Add stubs for JDK 21 Sequential Collections to allow for linkling when using JDK 21+ * CI - Test JDK 21 only on Scala 2.13, compilation fails in Scala 3
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 13, 2023
* `Thread.Builder.allowSetThreadLocals` didn't made it to stable release, and is only available in JDK 19-20 until --preview flag. Remove it's implementation and tests referencing this no longer existing API * Update CI to test against JDK 21 instead of JDK 20 with --enable-preview flags * Don't warn when accessing `Thread.getId()` which is deprecated in latest JDK versions * Add stubs for JDK 21 Sequential Collections to allow for linkling when using JDK 21+ * CI - Test JDK 21 only on Scala 2.13, compilation fails in Scala 3 (cherry picked from commit 4eb7261)
WojciechMazur
added a commit
that referenced
this pull request
Oct 13, 2023
* `Thread.Builder.allowSetThreadLocals` didn't made it to stable release, and is only available in JDK 19-20 until --preview flag. Remove it's implementation and tests referencing this no longer existing API * Update CI to test against JDK 21 instead of JDK 20 with --enable-preview flags * Don't warn when accessing `Thread.getId()` which is deprecated in latest JDK versions * Add stubs for JDK 21 Sequential Collections to allow for linkling when using JDK 21+ * CI - Test JDK 21 only on Scala 2.13, compilation fails in Scala 3 (cherry picked from commit 4eb7261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread.Builder.allowSetThreadLocalswhich didn't made it to stable release and is available only under preview API (JDK 19-20)