Preserve more information about unreachable symbols #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
reviewed
Oct 5, 2023
| val (name, typeInfo) = | ||
| if (argTypes.nonEmpty) descriptor.splitAt(descriptor.indexOf("(")) | ||
| else (descriptor, "") | ||
| modifiers -> s"$BOLD$YELLOW$name$RESET$typeInfo at $BOLD$filename:$line" |
There was a problem hiding this comment.
I don't think AnsiColor respects the various colour disabling env flags (see https://no-color.org/ and https://clig.dev/#output in general), but it'd be good to respect the env variable (+ whatever color information the build tool can give us) so that the output of the build tooling can be processed easier.
There was a problem hiding this comment.
Not sure about the other build tools, but running sbt with --color=false is able to filter out all ANSI modifiers on its own. I'm not sure if we're able to disable colors in scala-cli at all.
Anyway I'll the NO_COLOR env variable to allow for disabling coloring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #3532 I've found out that current unreachable symbols don't contain information about argument/result types of unreachable symbol. This made debuggin harder, when the issue were the differencing argument type lists.
This PR improves unreachable symbols stacktraces by adding more information, and adapts the backtrace loggin to use additional informaiton. It also improves formatting of backtraces to make them more readable.