Skip addr memcmp if getifaddrs returns a null ifa_addr pointer #3626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the
getifaddrs
man page, theifa_addr
contained in theifaddrs
struct can be a null pointer.When running the
org.scalanative.testsuite.javalib.net.NetworkInterfaceTest
unit-test on my machine, I have the following errorAdding null check so
found
returnsfalse
and lookup continues to nextifaddrs
record.