fix: Fix accessing mapped byte buffers if offset is not page size alligned #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
changed the title
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Jan 25, 2024
…igned (scala-native#3679) * Fix accessing mapped byte buffers if offset is not page alligned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening MappedByteBuffer with a position offset not being page size alligned would lead to failure in creating mapping using mmap or it's Windows counterpart. This PR fixes that and ensure we use correct page size alligned values. Also improves context of buffer exceptions for out of bounds and under/overflow exceptions. Additionally fixes usage of "empty" MappedByteBufferData, previous usage was only defining local methods which were never used, now we create an overriden instance.