improvement: Add most of missing JDK9+ methods for java.nio buffers
#3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with decoupling BufferAdapters for API introduced in JDK9+
…lude them in Build def
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Jan 24, 2024
… buffers (scala-native#3681)" This reverts commit b07d16e.
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Jan 24, 2024
… buffers (scala-native#3681)" This reverts commit b07d16e.
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Jan 25, 2024
…scala-native#3681) * Fix accessing mapped byte buffers if offset is not page alligned * Use template to define base java nio buffer types * Add JDK13 method Buffer.slice(Int,Int) * Add absolute bulk offset get/put methods * Add tests for alignment offsets/slices * Move ALL java.nio buffer tests to require-jdk16 subdir due to problems with decoupling BufferAdapters for API introduced in JDK9+ * Fix build, move remaining buffer tests to required-jdk16 sources, exclude them in Build def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mising absolute bulk get/put operations for java NIO buffers and some other not yet implemented methods. After this PR there remains only 1 missing method added after JDK8:
mismatch.The follow up PR might contain performance improvements for copying between non-array based buffers
All basic buffers are now generated from template to reduce ammount of copy-pasting and related with that bugs