Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Better source positions relativization #3695

Merged
merged 6 commits into from Jan 19, 2024
Merged

improvement: Better source positions relativization #3695

merged 6 commits into from Jan 19, 2024

Conversation

WojciechMazur
Copy link
Contributor

  • Allows to define custom relativization paths - previous solution based on -sourcepath,-sourceroot could have impacted compilations (like it did in scalalib for Scala 2) and was not handling custom paths well (see scalalib and it's fetched/patched sources)
  • In codegen split files by directory and not be package - fixes again issue with reporting missing symbols on x86_64 macos when multiple packages were defined in the same file.
  • Rename nir.SourceFile.SourceRootRelative to nir.SourceFile.Relative
  • In sbt prepopulate custom relativization paths by default using configured source directories.
  • Fix generation of illegal names for reflective instantiation constructors - use index instead of mangled constructor signature.

@WojciechMazur WojciechMazur merged commit 71a1b2f into scala-native:main Jan 19, 2024
57 of 62 checks passed
WojciechMazur added a commit to WojciechMazur/scala-native that referenced this pull request Jan 25, 2024
@WojciechMazur
improvement: Better source positions relativization (scala-native#3695)
f82a910 
* Fix illegal identifiers for Reflective instantinised ctors
* Use source directory instead of package, split by directory instead of jar:directory
* Allow to define custom relativization paths
* Fix invalid empty pathspositionRelativizationPaths
* Better resolving of local files
@WojciechMazur WojciechMazur deleted the fix/codegen-debug-symbols branch February 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@WojciechMazur