Fix #3707: javalib Inet6Address#hashCode is now more robust to null hostnames #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st to null hostnames
LeeTibbert
added
component:javalib
backport candidate
LeeTibbert
changed the title
LeeTibbert
changed the title
|
I believe this PR is ready for review. As per usual, I reviewed the logs of the failing tests. Those failures are the usual suspects. |
He-Pin
approved these changes
Jan 24, 2024
| @@ -45,7 +45,8 @@ final class Inet6Address private ( | |||
| override def hashCode(): Int = { | |||
| var res = 1 | |||
| res = 31 * res + ju.Arrays.hashCode(ipAddress) | |||
There was a problem hiding this comment.
Good catch! Thank you.
It is not evident to a reviewer and certainly not to me when I wrote it, but ju.Arrays.hashCode(null)
always returns 0. That is both robust sensible.
I added a comment to remind myself and others who try to verify that method in the future.
A runtime test would have been the alternative. I went with a comment to save a few cpu
cycles when run.
Dratted nulls!
|
I believe this PR is ready for review. As is my practice, I examined the log files of the tests which have completed as of the end |
WojciechMazur
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3707:
javalib
Inet6Address#hashCodeis now more robust to null hostnames.