Fix #3706: java.net.ServerSocket now reports local address of accepted socket correctly #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of accepted socket correctly
|
This PR was tested manually with private code. The addresses in question change frequently, so |
|
I believe this PR is ready for review, when its time comes around. Thank you. As is my usual practice, I took a quick look at the log files. Sorry if I missed any |
WojciechMazur
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3706
java.net.ServerSocket#acceptnow correctly sets the local address of the Socket it returns.This means that
Socketnow reports the correct/expected address.Previously it had been reporting the "any" or "wildcard" address
0.0.0.0or its IPv6 equivalent.