Fix #3708: javalib Inet6Address ipv6Address argumentsare now resistant to outside change. #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR is ready for review when its turn comes around. Examined the log file of failing tests: Same song, next verse. |
LeeTibbert
changed the title
WojciechMazur
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3708
The ipv6Address argument to javalib
Inet6Addressconstructors is now defensively copied.This makes them effectively immutable to callers.
A change was also made to
InetAddressequals() method to avoid the overhead of cloning the ipv6Address.This also changed the semantics of the test from the previous loose "the address bytes match" to a more
Java/Scala idiomatic "the fields of the object match". Meaning that the hostnames, if any must match.
A "" hostname will not match a hostname.