Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross-compiling from Mac to Linux and vice versa #3716

Merged
merged 2 commits into from Jan 29, 2024

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jan 28, 2024

Currently, targetsMac returns true even if the target triple explicitly says "use linux". The opposite is also true.

This PR updates these checks so that they're consistent with the others, e.g. targetsWindows - looking at the target triple first, and only using the current platform (which is derived from the os.name sysprop).

@LeeTibbert
Copy link
Contributor

@kubukoz

Thank you for the PR.

FYI, the mainline build is experiencing some know glitches, especially with Scala 2. So if you see a
bunch of build failures, it is worth examining the log file to see if the failure is with this PR or with
the build itself. I believe a fix for the glitches is being worked on.

@WojciechMazur WojciechMazur merged commit ba2bd19 into scala-native:main Jan 29, 2024
54 of 62 checks passed
@kubukoz kubukoz deleted the cross-compile-from-mac branch January 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants